On 2018-05-04 17:54:46 [+0200], Peter Zijlstra wrote: > On Fri, May 04, 2018 at 05:45:28PM +0200, Sebastian Andrzej Siewior wrote: > > This series introduces atomic_dec_and_lock_irqsave() and converts a few > > users to use it. They were using local_irq_save() + > > atomic_dec_and_lock() before that series. > > Should not all these users be converted to refcount_t, and thus, should > we not introduce refcount_dec_and_lock_irqsave() instead? do you intend to kill refcount_dec_and_lock() in the longterm? I haz this but instead we do - atomic_dec_and_lock() -> refcount_dec_and_lock() - add refcount_dec_and_lock_irqsave() - patch 2+ use refcount_dec_and_lock_irqsave(). Sebastian