On Wed, 2 May 2018 11:47:37 +0530 Souptick Joarder <jrdr.linux@xxxxxxxxx> wrote: > >> few different ways, but > >> > >> ret = (err == -ENOMEM) ? VM_FAULT_OOM : VM_FAULT_SIGBUS; > >> > >> is really common. I think we should do a helper function as part of > >> these cleanups ... maybe: > >> (top-posting repaired. Please don't top-post) > Hi Andrew, > > Any further comment on this patch ? > Around 10 drivers/file systems changes (vm_fault_t type changes) > depend on this patch. Well I think we're expecting a new version which is coded less verbosely? Also, Matthew's comments up-thread would be a welcome addition to the changelog.