Re: [PATCH 00/24] Refactor sys_swapon

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 12 Feb 2011, Cesar Eduardo Barros wrote:

> This patch series refactors the sys_swapon function.
> 
> sys_swapon is currently a very large function, with 313 lines (more
> than 12 25-line screens), which can make it a bit hard to read. This
> patch series reduces this size by half, by extracting large chunks
> of related code to new helper functions.
> 
> One of these chunks of code was nearly identical to the part of
> sys_swapoff which is used in case of a failure return from
> try_to_unuse(), so this patch series also makes both share the same
> code.
> 
> As a side effect of all this refactoring, the compiled code gets a
> bit smaller:
> 
>    text	   data	    bss	    dec	    hex	filename
>   14012	    944	    276	  15232	   3b80	mm/swapfile.o.before
>   13941	    944	    276	  15161	   3b39	mm/swapfile.o.after
> 
> Lightly tested on a x86_64 VM.

I have been working on reviewing/testing this set and I cannot get it
to apply to Linus' tree, what is this set based on?

Thanks,
Eric

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]