On Mon, Apr 23, 2018 at 09:42:30PM +0530, Souptick Joarder wrote: > > OK, fair enough and thanks for doing an audit! So possibly just add a > > comment above vmf_insert_mixed() and vmf_insert_mixed_mkwrite() like: > > > > /* > > * If the insertion of PTE failed because someone else already added a > > * different entry in the mean time, we treat that as success as we assume > > * the same entry was actually inserted. > > */ > > > > After that feel free to add: > > > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > > > to the patch. > > > > Thanks , will add this in change log and send v4. Jan asked you to add this comment above vmf_insert_mixed_mkwrite() (I don't think it needs to be added above vmf_insert_mixed() because this comment will get moved in a later commit once we have no more callers of vm_insert_mixed()).
