On 04/20/2018 08:34 PM, Matthew Wilcox wrote: > On Fri, Apr 20, 2018 at 07:00:47AM -0500, Goldwyn Rodrigues wrote: >> This function name sounds like you are performing the operation for each >> tag. >> >> Can it be called xas_for_each_tagged() or xas_tag_for_each() instead? > > I hadn't thought of that interpretation. Yes, that makes sense. > Should we also rename xas_find_tag -> xas_find_tagged and xas_next_tag > -> xas_next_tagged? Yup. The family of functions that work with one tag should be renamed. I am fine with the names suggested. -- Goldwyn
