On 02/26, Linus Torvalds wrote: > > On Sat, Feb 26, 2011 at 4:37 AM, Oleg Nesterov <oleg@xxxxxxxxxx> wrote: > >> > > Otherwise, get_arg_ptr() should return conditional_user_ptr_t as well, > > No it shouldn't. (Yes I am stupid, see the next email). > and notice how it gets the types right, and it even has one line LESS > than your version, exactly because it gets the types right and doesn't > need that implied cast in your > > compat_uptr_t *a = argv; > > (in fact, I think your version needs an _explicit_ cast in order to > not get a warning: you can't just cast "void **" to something else). Yes, and get_user(argv) in the !compat case doesn't look nice, I agree. > See? The advantage of the union is that the types are correct, which > means that the casts are unnecessary. My point was, apart from the trivial get_arg_ptr() helper, nobody else uses this argv/envp, so I thought it is OK to drop the type info and use "void *". But as I said, I won't insist. I'll redo/resend. Thanks. Oleg. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>