On Tue, Apr 3, 2018 at 6:09 PM, Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx> wrote: > Changes from v3: > * Fix whitespace issue noticed by willy > * Clarify comments about X86_FEATURE_PGE checks > * Clarify commit message around the necessity of _PAGE_GLOBAL > filtering when CR4.PGE=0 or PGE is unsupported. I couldn't see anything odd in this, but I only read the explanations and the patches, and the devil is in the details. But it all looks sane to me, and the added comments all seemed like good ideas. Plus the performance numbers certainly speak for themselves, even if the big changes are from that Atom microserver that I probably personally wouldn't want to use anyway ;). So Ack from me, maybe a weak review. Linus