On Thu, 22 Mar 2018 12:10:03 -0400 Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > > The trace event trace_mm_vmscan_lru_shrink_inactive() currently has 12 > parameters! Seven of them are from the reclaim_stat structure. This > structure is currently local to mm/vmscan.c. By moving it to the global > vmstat.h header, we can also reference it from the vmscan tracepoints. In > moving it, it brings down the overhead of passing so many arguments to the > trace event. In the future, we may limit the number of arguments that a > trace event may pass (ideally just 6, but more realistically it may be 8). Unfortunately this is not a good time. Andrey's "mm/vmscan: replace mm_vmscan_lru_shrink_inactive with shrink_page_list tracepoint" mucks with this code quite a lot and that patch's series is undergoing review at present, with a few issues yet unresolved. I'll park your patch for now and if Andrey's series doesn't converge soon I'll merge this and will ask Andrey to redo things.
