Hi Ravi, On Wed, 14 Mar 2018 20:52:59 +0530 Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx> wrote: > On 03/14/2018 07:20 PM, Masami Hiramatsu wrote: > > On Tue, 13 Mar 2018 18:26:03 +0530 > > Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx> wrote: > > > >> No functionality changes. > > Please consider to describe what is this change and why, here. > > Will add in next version. Thanks, and could you also move this before perf-probe patch? Also Could you make perf-probe check the tracing/README whether the kernel supports reference counter syntax or not? perf-tool can be used on older (or stable) kernel. Thank you, > > >> Signed-off-by: Ravi Bangoria <ravi.bangoria@xxxxxxxxxxxxxxxxxx> > >> --- > >> Documentation/trace/uprobetracer.txt | 16 +++++++++++++--- > >> kernel/trace/trace.c | 2 +- > >> 2 files changed, 14 insertions(+), 4 deletions(-) > >> > >> diff --git a/Documentation/trace/uprobetracer.txt b/Documentation/trace/uprobetracer.txt > >> index bf526a7c..8fb13b0 100644 > >> --- a/Documentation/trace/uprobetracer.txt > >> +++ b/Documentation/trace/uprobetracer.txt > >> @@ -19,15 +19,25 @@ user to calculate the offset of the probepoint in the object. > >> > >> Synopsis of uprobe_tracer > >> ------------------------- > >> - p[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a uprobe > >> - r[:[GRP/]EVENT] PATH:OFFSET [FETCHARGS] : Set a return uprobe (uretprobe) > >> - -:[GRP/]EVENT : Clear uprobe or uretprobe event > >> + p[:[GRP/]EVENT] PATH:OFFSET[(REF_CTR_OFFSET)] [FETCHARGS] > >> + r[:[GRP/]EVENT] PATH:OFFSET[(REF_CTR_OFFSET)] [FETCHARGS] > > Ah, OK in this context, [] means optional syntax :) > > Correct. > > Thanks, > Ravi > -- Masami Hiramatsu <mhiramat@xxxxxxxxxx>
