On Tue, Mar 13, 2018 at 3:44 PM, Alexander Potapenko <glider@xxxxxxxxxx> wrote: > On Fri, Mar 2, 2018 at 8:44 PM, Andrey Konovalov <andreyknvl@xxxxxxxxxx> wrote: >> There are two reasons to use outline instrumentation: >> 1. Outline instrumentation reduces the size of the kernel text, and should >> be used where this size matters. >> 2. Outline instrumentation is less invasive and can be used for debugging >> for KASAN developers, when it's not clear whether some issue is caused >> by KASAN or by something else. > > Don't you think this patch can be landed separately from the KHWASAN series? Sure, I can mail it separately. > >> For the rest cases inline instrumentation is preferrable, since it's >> faster. >> >> This patch changes the default instrumentation mode to inline. >> --- >> lib/Kconfig.kasan | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/Kconfig.kasan b/lib/Kconfig.kasan >> index ab34e7d7d3a7..8ea6ae26b4a3 100644 >> --- a/lib/Kconfig.kasan >> +++ b/lib/Kconfig.kasan >> @@ -70,7 +70,7 @@ config KASAN_EXTRA >> choice >> prompt "Instrumentation type" >> depends on KASAN >> - default KASAN_OUTLINE >> + default KASAN_INLINE >> >> config KASAN_OUTLINE >> bool "Outline instrumentation" >> -- >> 2.16.2.395.g2e18187dfd-goog >> > Reviewed-by: Alexander Potapenko <glider@xxxxxxxxxx> > > > > > -- > Alexander Potapenko > Software Engineer > > Google Germany GmbH > Erika-Mann-Straße, 33 > 80636 München > > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado > Registergericht und -nummer: Hamburg, HRB 86891 > Sitz der Gesellschaft: Hamburg
