On Fri, Feb 18, 2011 at 10:46 AM, Namhyung Kim <namhyung@xxxxxxxxx> wrote: > When pfn_valid_within() failed 'iter' was incremented twice. > > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxx> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Reviewed-by: Minchan Kim <minchan.kim@xxxxxxxxx> Nitpick. I am not sure it's best. I don't like below trick. iter += (1 << page_order(page)) - 1; So we can change for loop with while as removing -1 trick of PageBuddy. But if you don't like it, I don't mind it. :) Thanks! -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>