Hi Borislav, Borislav Petkov <bp@xxxxxxxxx> writes: > On Thu, Feb 15, 2018 at 06:55:57PM +0000, James Morse wrote: >> Keep the oops_begin() call for x86, > > That oops_begin() in generic code is such a layering violation, grrr. > >> arm64 doesn't have one of these, >> and APEI is the only thing outside arch code calling this.. > > So looking at: > > arch/arm/kernel/traps.c:die() > > it does call oops_begin() ... oops_end() just like the x86 version of > die(). You're looking at support for the 32-bit ARM systems. The 64-bit support lives in arch/arm64 and the die() there doesn't contain an oops_begin()/oops_end(). But the lack of oops_begin() on arm64 doesn't really matter here. > > I'm wondering if we could move the code to do die() in a prepatch? My > assumption is that all the arches should have die()... A quick grep does > show a bunch of other arches having die()... One issue I see with calling die() is that it is defined in different includes across various architectures, (e.g., include/asm/kdebug.h for x86, include/asm/system_misc.h in arm64, etc.) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
