On Thu, 22 Feb 2018 17:11:28 +0800 Baoquan He <bhe@xxxxxxxxxx> wrote: > It's used to record how many memory sections are marked as present > during system boot up, and will be used in the later patch. > > --- a/mm/sparse.c > +++ b/mm/sparse.c > @@ -202,6 +202,7 @@ static inline int next_present_section_nr(int section_nr) > (section_nr <= __highest_present_section_nr)); \ > section_nr = next_present_section_nr(section_nr)) > > +static int nr_present_sections; I think this could be __initdata. A nice comment explaining why it exists would be nice. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>