On Tue 20-02-18 23:28:11, Souptick Joarder wrote:
[...]
> -static int zs_register_migration(struct zs_pool *pool)
> +static bool zs_register_migration(struct zs_pool *pool)
> {
> pool->inode = alloc_anon_inode(zsmalloc_mnt->mnt_sb);
> if (IS_ERR(pool->inode)) {
> pool->inode = NULL;
> - return 1;
> + return true;
> }
>
> pool->inode->i_mapping->private_data = pool;
> pool->inode->i_mapping->a_ops = &zsmalloc_aops;
> - return 0;
> + return false;
> }
Don't you find it a bit strange that the function returns false on
success?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
