On Tue, Feb 20, 2018 at 10:32:56PM +0900, Tetsuo Handa wrote: > > - /* > - * Acquire the oom lock. If that fails, somebody else is > - * making progress for us. > - */ > - if (!mutex_trylock(&oom_lock)) { > + if (mutex_lock_killable(&oom_lock)) { > *did_some_progress = 1; > schedule_timeout_uninterruptible(1); > return NULL; It looks odd to mutex_lock_killable() and then schedule_timeout_uninterruptible(). Why not schedule_timeout_killable()? If someone's sent a fatal signal, why delay for one jiffy? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>