On 02/19/18 11:42, Souptick Joarder wrote:
> zs_register_migration() returns either 0 or 1.
> So the return type int should be replaced with bool.
>
> Signed-off-by: Souptick Joarder <jrdr.linux@xxxxxxxxx>
> ---
> mm/zsmalloc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/mm/zsmalloc.c b/mm/zsmalloc.c
> index c301350..e238354 100644
> --- a/mm/zsmalloc.c
> +++ b/mm/zsmalloc.c
> @@ -295,7 +295,7 @@ struct mapping_area {
> };
>
> #ifdef CONFIG_COMPACTION
> -static int zs_register_migration(struct zs_pool *pool);
> +static bool zs_register_migration(struct zs_pool *pool);
> static void zs_unregister_migration(struct zs_pool *pool);
> static void migrate_lock_init(struct zspage *zspage);
> static void migrate_read_lock(struct zspage *zspage);
> @@ -306,7 +306,7 @@ struct mapping_area {
> #else
> static int zsmalloc_mount(void) { return 0; }
> static void zsmalloc_unmount(void) {}
> -static int zs_register_migration(struct zs_pool *pool) { return 0; }
> +static bool zs_register_migration(struct zs_pool *pool) { return 0; }
return false;
> static void zs_unregister_migration(struct zs_pool *pool) {}
> static void migrate_lock_init(struct zspage *zspage) {}
> static void migrate_read_lock(struct zspage *zspage) {}
> @@ -2101,17 +2101,17 @@ void zs_page_putback(struct page *page)
> .putback_page = zs_page_putback,
> };
>
> -static int zs_register_migration(struct zs_pool *pool)
> +static bool zs_register_migration(struct zs_pool *pool)
> {
> pool->inode = alloc_anon_inode(zsmalloc_mnt->mnt_sb);
> if (IS_ERR(pool->inode)) {
> pool->inode = NULL;
> - return 1;
> + return true;
> }
>
> pool->inode->i_mapping->private_data = pool;
> pool->inode->i_mapping->a_ops = &zsmalloc_aops;
> - return 0;
> + return false;
> }
>
> static void zs_unregister_migration(struct zs_pool *pool)
> --
thanks,
--
~Randy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
