Hi, On Thu, Feb 15, 2018 at 01:41:48PM -0800, Tejun Heo wrote: > On Thu, Feb 15, 2018 at 10:08:16AM -0600, Dennis Zhou wrote: > > +/* the whitelisted flags that can be passed to the backing allocators */ > > +#define gfp_percpu_mask(gfp) (((gfp) & (__GFP_NORETRY | __GFP_NOWARN)) | \ > > + GFP_KERNEL) > > Isn't there just one place where gfp comes in from outside? If so, > this looks like a bit of overkill. Can't we just filter there? > I agree, but it's also nice having a single place where flags can be added or removed. The primary motivator was for the "| GFP_KERNEL", but as suggested in the other patch this is getting removed. I guess I still lean towards having it as it's explicit and helps gate both the balance path and the user allocation path. Thanks, Dennis -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
