Hi Matthew, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on next-20180209] [cannot apply to v4.15] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Matthew-Wilcox/mm-Split-page_type-out-from-_map_count/20180210-114226 config: i386-randconfig-s1-201805 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to linux build tree make ARCH=i386 All errors (new ones prefixed by >>): In file included from kernel/crash_core.c:9:0: kernel/crash_core.c: In function 'crash_save_vmcoreinfo_init': >> kernel/crash_core.c:461:20: error: 'PAGE_BUDDY_MAPCOUNT_VALUE' undeclared (first use in this function) VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE); ^ include/linux/crash_core.h:59:57: note: in definition of macro 'VMCOREINFO_NUMBER' vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name) ^~~~ kernel/crash_core.c:461:20: note: each undeclared identifier is reported only once for each function it appears in VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE); ^ include/linux/crash_core.h:59:57: note: in definition of macro 'VMCOREINFO_NUMBER' vmcoreinfo_append_str("NUMBER(%s)=%ld\n", #name, (long)name) ^~~~ vim +/PAGE_BUDDY_MAPCOUNT_VALUE +461 kernel/crash_core.c 692f66f2 Hari Bathini 2017-05-08 379 692f66f2 Hari Bathini 2017-05-08 380 static int __init crash_save_vmcoreinfo_init(void) 692f66f2 Hari Bathini 2017-05-08 381 { 203e9e41 Xunlei Pang 2017-07-12 382 vmcoreinfo_data = (unsigned char *)get_zeroed_page(GFP_KERNEL); 203e9e41 Xunlei Pang 2017-07-12 383 if (!vmcoreinfo_data) { 203e9e41 Xunlei Pang 2017-07-12 384 pr_warn("Memory allocation for vmcoreinfo_data failed\n"); 203e9e41 Xunlei Pang 2017-07-12 385 return -ENOMEM; 203e9e41 Xunlei Pang 2017-07-12 386 } 203e9e41 Xunlei Pang 2017-07-12 387 203e9e41 Xunlei Pang 2017-07-12 388 vmcoreinfo_note = alloc_pages_exact(VMCOREINFO_NOTE_SIZE, 203e9e41 Xunlei Pang 2017-07-12 389 GFP_KERNEL | __GFP_ZERO); 203e9e41 Xunlei Pang 2017-07-12 390 if (!vmcoreinfo_note) { 203e9e41 Xunlei Pang 2017-07-12 391 free_page((unsigned long)vmcoreinfo_data); 203e9e41 Xunlei Pang 2017-07-12 392 vmcoreinfo_data = NULL; 203e9e41 Xunlei Pang 2017-07-12 393 pr_warn("Memory allocation for vmcoreinfo_note failed\n"); 203e9e41 Xunlei Pang 2017-07-12 394 return -ENOMEM; 203e9e41 Xunlei Pang 2017-07-12 395 } 203e9e41 Xunlei Pang 2017-07-12 396 692f66f2 Hari Bathini 2017-05-08 397 VMCOREINFO_OSRELEASE(init_uts_ns.name.release); 692f66f2 Hari Bathini 2017-05-08 398 VMCOREINFO_PAGESIZE(PAGE_SIZE); 692f66f2 Hari Bathini 2017-05-08 399 692f66f2 Hari Bathini 2017-05-08 400 VMCOREINFO_SYMBOL(init_uts_ns); 692f66f2 Hari Bathini 2017-05-08 401 VMCOREINFO_SYMBOL(node_online_map); 692f66f2 Hari Bathini 2017-05-08 402 #ifdef CONFIG_MMU 692f66f2 Hari Bathini 2017-05-08 403 VMCOREINFO_SYMBOL(swapper_pg_dir); 692f66f2 Hari Bathini 2017-05-08 404 #endif 692f66f2 Hari Bathini 2017-05-08 405 VMCOREINFO_SYMBOL(_stext); 692f66f2 Hari Bathini 2017-05-08 406 VMCOREINFO_SYMBOL(vmap_area_list); 692f66f2 Hari Bathini 2017-05-08 407 692f66f2 Hari Bathini 2017-05-08 408 #ifndef CONFIG_NEED_MULTIPLE_NODES 692f66f2 Hari Bathini 2017-05-08 409 VMCOREINFO_SYMBOL(mem_map); 692f66f2 Hari Bathini 2017-05-08 410 VMCOREINFO_SYMBOL(contig_page_data); 692f66f2 Hari Bathini 2017-05-08 411 #endif 692f66f2 Hari Bathini 2017-05-08 412 #ifdef CONFIG_SPARSEMEM a0b12803 Kirill A. Shutemov 2018-01-12 413 VMCOREINFO_SYMBOL_ARRAY(mem_section); 692f66f2 Hari Bathini 2017-05-08 414 VMCOREINFO_LENGTH(mem_section, NR_SECTION_ROOTS); 692f66f2 Hari Bathini 2017-05-08 415 VMCOREINFO_STRUCT_SIZE(mem_section); 692f66f2 Hari Bathini 2017-05-08 416 VMCOREINFO_OFFSET(mem_section, section_mem_map); 692f66f2 Hari Bathini 2017-05-08 417 #endif 692f66f2 Hari Bathini 2017-05-08 418 VMCOREINFO_STRUCT_SIZE(page); 692f66f2 Hari Bathini 2017-05-08 419 VMCOREINFO_STRUCT_SIZE(pglist_data); 692f66f2 Hari Bathini 2017-05-08 420 VMCOREINFO_STRUCT_SIZE(zone); 692f66f2 Hari Bathini 2017-05-08 421 VMCOREINFO_STRUCT_SIZE(free_area); 692f66f2 Hari Bathini 2017-05-08 422 VMCOREINFO_STRUCT_SIZE(list_head); 692f66f2 Hari Bathini 2017-05-08 423 VMCOREINFO_SIZE(nodemask_t); 692f66f2 Hari Bathini 2017-05-08 424 VMCOREINFO_OFFSET(page, flags); 692f66f2 Hari Bathini 2017-05-08 425 VMCOREINFO_OFFSET(page, _refcount); 692f66f2 Hari Bathini 2017-05-08 426 VMCOREINFO_OFFSET(page, mapping); 692f66f2 Hari Bathini 2017-05-08 427 VMCOREINFO_OFFSET(page, lru); 692f66f2 Hari Bathini 2017-05-08 428 VMCOREINFO_OFFSET(page, _mapcount); 692f66f2 Hari Bathini 2017-05-08 429 VMCOREINFO_OFFSET(page, private); 692f66f2 Hari Bathini 2017-05-08 430 VMCOREINFO_OFFSET(page, compound_dtor); 692f66f2 Hari Bathini 2017-05-08 431 VMCOREINFO_OFFSET(page, compound_order); 692f66f2 Hari Bathini 2017-05-08 432 VMCOREINFO_OFFSET(page, compound_head); 692f66f2 Hari Bathini 2017-05-08 433 VMCOREINFO_OFFSET(pglist_data, node_zones); 692f66f2 Hari Bathini 2017-05-08 434 VMCOREINFO_OFFSET(pglist_data, nr_zones); 692f66f2 Hari Bathini 2017-05-08 435 #ifdef CONFIG_FLAT_NODE_MEM_MAP 692f66f2 Hari Bathini 2017-05-08 436 VMCOREINFO_OFFSET(pglist_data, node_mem_map); 692f66f2 Hari Bathini 2017-05-08 437 #endif 692f66f2 Hari Bathini 2017-05-08 438 VMCOREINFO_OFFSET(pglist_data, node_start_pfn); 692f66f2 Hari Bathini 2017-05-08 439 VMCOREINFO_OFFSET(pglist_data, node_spanned_pages); 692f66f2 Hari Bathini 2017-05-08 440 VMCOREINFO_OFFSET(pglist_data, node_id); 692f66f2 Hari Bathini 2017-05-08 441 VMCOREINFO_OFFSET(zone, free_area); 692f66f2 Hari Bathini 2017-05-08 442 VMCOREINFO_OFFSET(zone, vm_stat); 692f66f2 Hari Bathini 2017-05-08 443 VMCOREINFO_OFFSET(zone, spanned_pages); 692f66f2 Hari Bathini 2017-05-08 444 VMCOREINFO_OFFSET(free_area, free_list); 692f66f2 Hari Bathini 2017-05-08 445 VMCOREINFO_OFFSET(list_head, next); 692f66f2 Hari Bathini 2017-05-08 446 VMCOREINFO_OFFSET(list_head, prev); 692f66f2 Hari Bathini 2017-05-08 447 VMCOREINFO_OFFSET(vmap_area, va_start); 692f66f2 Hari Bathini 2017-05-08 448 VMCOREINFO_OFFSET(vmap_area, list); 692f66f2 Hari Bathini 2017-05-08 449 VMCOREINFO_LENGTH(zone.free_area, MAX_ORDER); 692f66f2 Hari Bathini 2017-05-08 450 log_buf_vmcoreinfo_setup(); 692f66f2 Hari Bathini 2017-05-08 451 VMCOREINFO_LENGTH(free_area.free_list, MIGRATE_TYPES); 692f66f2 Hari Bathini 2017-05-08 452 VMCOREINFO_NUMBER(NR_FREE_PAGES); 692f66f2 Hari Bathini 2017-05-08 453 VMCOREINFO_NUMBER(PG_lru); 692f66f2 Hari Bathini 2017-05-08 454 VMCOREINFO_NUMBER(PG_private); 692f66f2 Hari Bathini 2017-05-08 455 VMCOREINFO_NUMBER(PG_swapcache); 692f66f2 Hari Bathini 2017-05-08 456 VMCOREINFO_NUMBER(PG_slab); 692f66f2 Hari Bathini 2017-05-08 457 #ifdef CONFIG_MEMORY_FAILURE 692f66f2 Hari Bathini 2017-05-08 458 VMCOREINFO_NUMBER(PG_hwpoison); 692f66f2 Hari Bathini 2017-05-08 459 #endif 692f66f2 Hari Bathini 2017-05-08 460 VMCOREINFO_NUMBER(PG_head_mask); 692f66f2 Hari Bathini 2017-05-08 @461 VMCOREINFO_NUMBER(PAGE_BUDDY_MAPCOUNT_VALUE); 692f66f2 Hari Bathini 2017-05-08 462 #ifdef CONFIG_HUGETLB_PAGE 692f66f2 Hari Bathini 2017-05-08 463 VMCOREINFO_NUMBER(HUGETLB_PAGE_DTOR); 692f66f2 Hari Bathini 2017-05-08 464 #endif 692f66f2 Hari Bathini 2017-05-08 465 692f66f2 Hari Bathini 2017-05-08 466 arch_crash_save_vmcoreinfo(); 692f66f2 Hari Bathini 2017-05-08 467 update_vmcoreinfo_note(); 692f66f2 Hari Bathini 2017-05-08 468 692f66f2 Hari Bathini 2017-05-08 469 return 0; 692f66f2 Hari Bathini 2017-05-08 470 } 692f66f2 Hari Bathini 2017-05-08 471 :::::: The code at line 461 was first introduced by commit :::::: 692f66f26a4c19d73249736aa973c13a1521b387 crash: move crashkernel parsing and vmcore related code under CONFIG_CRASH_CORE :::::: TO: Hari Bathini <hbathini@xxxxxxxxxxxxxxxxxx> :::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx> --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
