On (02/09/18 13:11), Mike Rapoport wrote: [..] > > +/** > > + * zs_huge_object() - Test if a compressed object's size is too big for normal > > + * zspool classes and it will be stored in a huge class. > > Maybe "it should be stored ..."? Agreed. > > + * @sz: Size in bytes of the compressed object. > > + * > > + * The functions checks if the object's size falls into huge_class area. > > + * We must take ZS_HANDLE_SIZE into account and test the actual size we > > ^ %ZS_HANDLE_SIZE Indeed. ``%CONST`` > > + * are going to use up, because zs_malloc() unconditionally adds the > > I think 's/use up/use/' here Agreed. > > + * handle size before it performs size_class lookup. > > ^ &size_class OK. ``&struct name`` Thanks for reviewing it! -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>