On 02/06/2018 10:33 AM, Matthew Wilcox wrote:
static inline void xas_maybe_lock_irq(struct xa_state *xas, void *entry)
{
if (entry) {
rcu_read_lock();
xas_start(&xas);
if (!xas_bounds(&xas))
return;
}
Trying to understand what's going on here.
xas_bounds isn't in your latest two XArray branches (xarray-4.16 or
xarray-2018-01-09). Isn't it checking whether 'entry' falls inside the
currently allocated range of the XArray? So that it should tell us
whether a new xa_node needs to be allocated for 'entry'?
If that's true, I guess it should take 'entry' as well as '&xas'.
Daniel
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
