On Thu, Feb 10, 2011 at 10:18 PM, Namhyung Kim <namhyung@xxxxxxxxx> wrote: > 2011-02-10 (ë), 22:10 +0900, Minchan Kim: >> Hello Namhyung, >> > > Hi Minchan, > > >> On Thu, Feb 10, 2011 at 8:46 PM, Namhyung Kim <namhyung@xxxxxxxxx> wrote: >> > Now I'm seeing that there are some cases to free all pages in a >> > pcp lists. In that case, just frees all pages in the lists instead >> > of being bothered with round-robin lists traversal. >> >> I though about that but I didn't send the patch. >> That's because many cases which calls free_pcppages_bulk(, >> pcp->count,..) are slow path so it adds comparison overhead on fast >> path while it loses the effectiveness in slow path. >> > > Hmm.. How about adding unlikely() then? Doesn't it help much here? Yes. It would help but I am not sure how much it is. AFAIR, when Mel submit the patch, he tried to prove the effectiveness with some experiment and profiler. I think if you want it really, we might need some number. I am not sure it's worth. -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href