On Wed, Jan 17, 2018 at 11:02:24AM +0100, Vlastimil Babka wrote:
> On 01/10/2018 09:43 AM, Oscar Salvador wrote:
> > This patch removes two redundant assignments in init_pages_in_zone function.
> >
> > Signed-off-by: Oscar Salvador <osalvador@xxxxxxxxxxxxxxxxxx>
>
> Acked-by: Vlastimil Babka <vbabka@xxxxxxx>
>
> A nitpick below.
>
> > ---
> > mm/page_owner.c | 7 ++-----
> > 1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/mm/page_owner.c b/mm/page_owner.c
> > index 69f83fc763bb..b361781e5ab6 100644
> > --- a/mm/page_owner.c
> > +++ b/mm/page_owner.c
> > @@ -528,14 +528,11 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos)
> >
> > static void init_pages_in_zone(pg_data_t *pgdat, struct zone *zone)
> > {
> > - struct page *page;
> > - struct page_ext *page_ext;
> > unsigned long pfn = zone->zone_start_pfn, block_end_pfn;
>
> block_end_pfn declaration could be moved to the outer for loop
>
> > unsigned long end_pfn = pfn + zone->spanned_pages;
>
> While here, I would use zone_end_pfn() on the line above.
>
> > unsigned long count = 0;
> >
> > /* Scan block by block. First and last block may be incomplete */
>
> Now the comment is stray, I would just remove it too.
Hi Vlastimil, thanks for the fixes.
I'll send v3 with your suggestions.
Thanks
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
