* Tony Luck <tony.luck@xxxxxxxxx> wrote:
> v1->v2 0-day reported a build warning on 32-bit. Don't do 32-bit (see comment
> at end of commit message). This fixed the build error, but then discussion on
> the list went quiet. Repost to wake things up.
It seems dubious to me to introduce a difference in behavior on 32-bit:
> +static void mce_unmap_kpfn(unsigned long pfn)
> +{
> +#ifdef CONFIG_X86_64
> + unsigned long decoy_addr;
> + if (set_memory_np(decoy_addr, 1))
> + pr_warn("Could not invalidate pfn=0x%lx from 1:1 map\n", pfn);
> +#endif
... to fix a build warning?
32-bit kernels might be under-tested, but if it's supposed to work I don't think
we should bifurcate the behavior and uglify the code here.
Thanks,
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
