On Tue, Jan 18, 2011 at 09:21:51AM -0800, Dan Magenheimer wrote: > [PATCH V1 3/3] drivers/staging: kztmem: misc build/config > > Makefiles and Kconfigs to build kztmem in drivers/staging > > There is a dependency on xvmalloc.* which in 2.6.37 resides > in drivers/staging/zram. Should this move or disappear, > some Makefile/Kconfig changes will be required. There is some other kind of dependancy as well, because I get the following errors when building: drivers/staging/kztmem/kztmem.c:34:2: error: #error "kztmem is useless without CONFIG_CLEANCACHE or CONFIG_FRONTSWAP" drivers/staging/kztmem/kztmem.c:531:13: warning: âzbud_initâ defined but not used drivers/staging/kztmem/kztmem.c:883:28: warning: âkztmem_hostopsâ defined but not used drivers/staging/kztmem/kztmem.c:988:27: warning: âkztmem_pamopsâ defined but not used drivers/staging/kztmem/kztmem.c:1063:30: warning: âkztmem_cpu_notifier_blockâ defined but not used drivers/staging/kztmem/kztmem.c:1201:24: warning: âkztmem_shrinkerâ defined but not used drivers/staging/kztmem/kztmem.c:1210:12: warning: âkztmem_put_pageâ defined but not used drivers/staging/kztmem/kztmem.c:1242:12: warning: âkztmem_get_pageâ defined but not used drivers/staging/kztmem/kztmem.c:1259:12: warning: âkztmem_flush_pageâ defined but not used drivers/staging/kztmem/kztmem.c:1278:12: warning: âkztmem_flush_objectâ defined but not used drivers/staging/kztmem/kztmem.c:1297:12: warning: âkztmem_destroy_poolâ defined but not used drivers/staging/kztmem/kztmem.c:1320:12: warning: âkztmem_new_poolâ defined but not used drivers/staging/kztmem/kztmem.c:1558:19: warning: âenable_kztmemâ defined but not used drivers/staging/kztmem/kztmem.c:1569:19: warning: âno_cleancacheâ defined but not used drivers/staging/kztmem/kztmem.c:1579:19: warning: âno_frontswapâ defined but not used If you require a kbuild dependancy, then put it in your Kconfig file please, don't break the build. I'll not apply these patches for now until that's fixed up. thanks, greg k-h -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>