Re: [mmotm:master 152/256] mm/migrate.c:1934:53: sparse: incorrect type in argument 2 (different argument counts)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri 05-01-18 12:42:39, Andrew Morton wrote:
> On Fri, 5 Jan 2018 15:29:12 +0800 kbuild test robot <fengguang.wu@xxxxxxxxx> wrote:
> 
> > Hi Michal,
> > 
> > First bad commit (maybe != root cause):
> > 
> > tree:   git://git.cmpxchg.org/linux-mmotm.git master
> > head:   1ceb98996d2504dd4e0bcb5f4cb9009a18cd8aaa
> > commit: 37870392dd6966328ed2fe49a247ab37d6fa7344 [152/256] mm, hugetlb: unify core page allocation accounting and initialization
> > reproduce:
> >         # apt-get install sparse
> >         git checkout 37870392dd6966328ed2fe49a247ab37d6fa7344
> >         make ARCH=x86_64 allmodconfig
> >         make C=1 CF=-D__CHECK_ENDIAN__
> > 
> > 
> 
> --- a/mm/migrate.c~mm-migrate-remove-reason-argument-from-new_page_t-fix-fix
> +++ a/mm/migrate.c
> @@ -1784,8 +1784,7 @@ static bool migrate_balanced_pgdat(struc
>  }
>  
>  static struct page *alloc_misplaced_dst_page(struct page *page,
> -					   unsigned long data,
> -					   int **result)
> +					   unsigned long data)
>  {
>  	int nid = (int) data;
>  	struct page *newpage;
> _
> 
> That's against mm-migrate-remove-reason-argument-from-new_page_t.patch.

Yeah http://lkml.kernel.org/r/20180105090753.GI2801@xxxxxxxxxxxxxx
and another that sneaked in http://lkml.kernel.org/r/20180105085259.GH2801@xxxxxxxxxxxxxx

I really do not know how this passed my standard build test batery.
Something must have been clearly broken there.

-- 
Michal Hocko
SUSE Labs

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux