On Fri 05-01-18 12:41:22, Cristopher Lameter wrote: > On Fri, 5 Jan 2018, Michal Hocko wrote: > > > I believe there should be some cap on the number of pages. We shouldn't > > keep it held for million of pages if all of them are moved to the same > > node. I would really like to postpone that to later unless it causes > > some noticeable regressions because this would complicate the code > > further and I am not sure this is all worth it. > > Attached a patch to make the code more readable. > > Also why are you migrating the pages on pagelist if a > add_page_for_migration() fails? One could simply update > the status in user space and continue. I am open to further cleanups. Care to send a full patch with the changelog? I would rather not fold more changes to the already tested one. Thanks! -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>