On Tue 02-01-18 11:08:47, Tetsuo Handa wrote: > virtio-balloon wants to try allocation only when that allocation does not cause > OOM situation. Since there is no gfp flag which succeeds allocations only if > there is plenty of free memory (i.e. higher watermark than other requests), > virtio-balloon needs to watch for OOM notifier and release just allocated memory > when OOM notifier is invoked. I do not understand the last part mentioning OOM notifier. > Currently virtio-balloon is using > > GFP_HIGHUSER[_MOVABLE] | __GFP_NOMEMALLOC | __GFP_NORETRY > > for allocation, but is > > GFP_HIGHUSER[_MOVABLE] | __GFP_NOMEMALLOC) & ~__GFP_DIRECT_RECLAIM > > supported (from MM subsystem's point of view) ? Semantically I do not see any reason why we shouldn't support non-sleeping user allocation with an explicit nomemalloc flag. Btw. why is __GFP_NOMEMALLOC needed at all? -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
