On (12/27/17 15:29), Minchan Kim wrote: > On Fri, Dec 22, 2017 at 04:00:06PM +0530, Gopi Sai Teja wrote: > > 75% of the PAGE_SIZE is not a correct threshold to store uncompressed > > Please describe it in detail that why current threshold is bad in that > memory efficiency point of view. > > > pages in zs_page as this must be changed if the maximum pages stored > > in zspage changes. Instead using zs classes, we can set the correct > > Also, let's include the pharase Sergey pointed out in this description. > > It's not a good idea that zram need to know allocator's implementation > with harded value like 75%. so I don't like that, basically, my work and my findings are now submitted by someone else without even crediting my work. not to mention that I like my commit message much better. -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>