On Fri 22-12-17 00:34:05, Tetsuo Handa wrote:
> Michal Hocko wrote:
[...]
> > Let me repeat something I've said a
> > long ago. We do not optimize for corner cases. We want to survive but if
> > an alternative is to kill another task then we can live with that.
> >
>
> Setting MMF_OOM_SKIP before all OOM-killed threads try memory reserves
> leads to needlessly selecting more OOM victims.
>
> Unless any OOM-killed thread fails to satisfy allocation even with ALLOC_OOM,
> no OOM-killed thread needs to select more OOM victims. Commit 696453e66630ad45
> ("mm, oom: task_will_free_mem should skip oom_reaped tasks") obviously broke
> it, which is exactly a regression.
You are trying to fix a completely artificial case. Or do you have any
example of an application which uses CLONE_VM without sharing signals?
--
Michal Hocko
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
