On Tue, 19 Dec 2017 18:56:51 -0600 (CST) Christopher Lameter <cl@xxxxxxxxx> wrote: > On Tue, 19 Dec 2017, Rao Shoaib wrote: > > > > > mm/slab_common.c > > > It would be great to have separate patches so that we can review it > > > properly: > > > > > > 1. Move the code into slab_common.c > > > 2. The actual code changes to the kfree rcu mechanism > > > 3. The whitespace changes > > > I can certainly break down the patch and submit smaller patches as you have > > suggested. > > > > BTW -- This is my first ever patch to Linux, so I am still learning the > > etiquette. > > You are doing great. Keep at improving the patches and we will get your > changes into the kernel source. If you want to sent your first patchset > then a tool like "quilt" or "git" might be helpful. When working with patchsets (multiple separate patches, as requested here), I personally prefer using the tool called Stacked Git[1] (StGit) command line 'stg', as it allows me to easily adjust patches in the middle of the patchset "stack". It is similar to quilt, just git based itself. I guess most people on this list use 'git rebase --interactive' when updating their patchsets (?) [1] http://procode.org/stgit/doc/tutorial.html -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
