On (12/19/17 20:45), Aliaksei Karaliou wrote: [..] > > OK, it smells like an abuse of the API but please add a comment > > clarifying that. > > > > Thanks! > I can update the existing comment to be like that: > /* > * Not critical since shrinker is only used to trigger internal > * de-fragmentation of the pool which is pretty optional thing. > * If registration fails we still can use the pool normally and > * user can trigger compaction manually. Thus, ignore return code. > */ > > Sergey, does this sound well to you ? Or not clear enough, Michal ? looks good. thanks! -ss -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>