On Tue, Dec 19, 2017 at 09:05:42AM -0800, Joe Perches wrote: > On Tue, 2017-12-19 at 08:58 -0800, Matthew Wilcox wrote: > > + /* (void) is needed to make gcc happy */ > > + (void) __cond_lock(*ptlp, > > + !(res = __follow_pte_pmd(mm, address, start, end, > > + ptepp, pmdpp, ptlp))); > > This seems obscure and difficult to read. Perhaps: > > res = __follow_pte_pmd(mm, address, start, end, ptepp, pmdpp, ptlp); > (void)__cond_lock(*ptlp, !res); Patch 1 moves the code. Patch 2 cleans it up ;-) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
