On Dec 14, 2017 21:04, "Dave Hansen" <dave.hansen@xxxxxxxxx> wrote:
On 12/14/2017 12:54 PM, Peter Zijlstra wrote:So, the underlying bug here is that we now a get_user_pages_remote() and
>> That short-circuits the page fault pretty quickly. So, basically, the
>> rule is: if the hardware says you tripped over pkey permissions, you
>> die. We don't try to do anything to the underlying page *before* saying
>> that you die.
> That only works when you trip the fault from hardware. Not if you do a
> software fault using gup().
>
> AFAIK __get_user_pages(FOLL_FORCE|FOLL_WRITE|FOLL_GET) will loop
> indefinitely on the case I described.
then go ahead and do the p*_access_permitted() checks against the
current PKRU. This was introduced recently with the addition of the new
p??_access_permitted() calls.
Can we please just undo that broken crap instead of trying to "fix" it?
It was wrong. We absolutely do not want to complicate the gup path.
Let's fet rid of those broken p??_access_permited() things.
Please.
Linus
