On Tue 05-12-17 15:34:22, Oscar Salvador wrote: > When we call register_page_bootmem_info_section() having CONFIG_SPARSEMEM_VMEMMAP enabled, > we check if the pfn is valid. > This check is redundant as we already checked this in register_page_bootmem_info_node() > before calling register_page_bootmem_info_section(), so let's get rid of it. there is quite a lot of legacy and confused code in memory hotplug. Some of it is really subtle but this one is really straightforward > Signed-off-by: Oscar Salvador <osalvador@xxxxxxxxxxxxxxxxxx> Acked-by: Michal Hocko <mhocko@xxxxxxxx> > --- > mm/memory_hotplug.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index d0856ab2f28d..7452a53b027f 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -200,9 +200,6 @@ static void register_page_bootmem_info_section(unsigned long start_pfn) > struct mem_section *ms; > struct page *page, *memmap; > > - if (!pfn_valid(start_pfn)) > - return; > - > section_nr = pfn_to_section_nr(start_pfn); > ms = __nr_to_section(section_nr); > > -- > 2.13.5 > -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
