On Wed 22-11-17 07:09:33, Tetsuo Handa wrote: > Andrew Morton wrote: [...] > > I'm not sure this is worth bothering about? > > > > Continuing with failed register_shrinker() is almost always wrong. > Though I don't know whether mm/zsmalloc.c case can make sense. Well, strictly speaking ignoring an error from _any_ function is almost always wrong. So I am not sure why __must_check is actually an improvement. -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>