On 11/20/2017 12:40 PM, Thomas Gleixner wrote: > On Fri, 10 Nov 2017, Dave Hansen wrote: >> >> +static int kaiser_user_map_ptr_early(const void *start_addr, unsigned long size, >> + unsigned long flags) >> +{ >> + int ret = kaiser_add_user_map(start_addr, size, flags); >> + WARN_ON(ret); >> + return ret; > What's the point of the return value when it is ignored at the call site? I'm dropping this patch, btw. It was unnecessary. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>