On Tue, Jan 25, 2011 at 03:05:16PM +0900, KAMEZAWA Hiroyuki wrote: > Based on > 2.6.38-rc2 + > mm-memcontrolc-fix-uninitialized-variable-use-in-mem_cgroup_move_parent.patch > == > From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> > > A fix up mem_cgroup_move_parent() which use compound_order() in > asynchrnous manner. This compound_order() may return unknown value > because we don't take lock. Use PageTransHuge() and HPAGE_SIZE instead of > it. > > Also clean up for mem_cgroup_move_parent(). > - remove unnecessary initialization of local variable. > - rename charge_size -> page_size > - remove unnecessary (wrong) comment. > - added a comment about THP. > > Changelog: > - fixed page size calculation for avoiding race. > > Note: > Current design take compound_page_lock() in caller of move_account(). > This should be revisited when we implement direct move_task of hugepage > without splitting. > > Signed-off-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Reviewed-by: Johannes Weiner <hannes@xxxxxxxxxxx> -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>