On 11/07/2017 06:07 AM, Nicholas Piggin wrote:
First of all, using addr and MAP_FIXED to develop our heuristic can never really give unchanged ABI. It's an in-band signal. brk() is a good example that steadily keeps incrementing address, so depending on malloc usage and address space randomization, you will get a brk() that ends exactly at 128T, then the next one will be > DEFAULT_MAP_WINDOW, and it will switch you to 56 bit address space.
Note that this brk phenomenon is only a concern for some currently obscure process memory layouts where the heap ends up at the top of the address space. Usually, there is something above it which eliminates the possibility that it can cross into the 128 TiB wilderness. So the brk problem only happens on some architectures (e.g., not x86-64), and only with strange ways of running programs (explicitly ld.so invocation and likely static PIE, too).
So unless everyone else thinks I'm crazy and disagrees, I'd ask for a bit more time to make sure we get this interface right. I would hope for something like prctl PR_SET_MM which can be used to set our user virtual address bits on a fine grained basis. Maybe a sysctl, maybe a personality. Something out-of-band. I don't wan to get too far into that discussion yet. First we need to agree whether or not the code in the tree today is a problem.
There is certainly more demand for similar functionality, like creating mappings below 2 GB/4 GB/32 GB, and probably other bit patterns. Hotspot would use this to place the heap with compressed oops, instead of manually hunting for a suitable place for the mapping. (Essentially, 32-bit pointers on 64-bit architectures for sufficiently small heap sizes.) It would perhaps be possible to use the hints address as a source of the bit count, for full flexibility. And the mapping should be placed into the upper half of the selected window if possible.
MAP_FIXED is near-impossible to use correctly. I hope you don't expect applications to do that. If you want address-based opt in, it should work without MAP_FIXED. Sure, in obscure cases, applications might still see out-of-range addresses, but I expected a full opt-out based on RLIMIT_AS would be sufficient for them.
Thanks, Florian -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
