On Sat, 22 Jan 2011 20:51:32 +0100 (CET) Jesper Juhl <jj@xxxxxxxxxxxxx> wrote: > In mm/memcontrol.c::mem_cgroup_move_parent() there's a path that jumps to > the 'put_back' label > ret = __mem_cgroup_try_charge(NULL, gfp_mask, &parent, false, charge); > if (ret || !parent) > goto put_back; > where we'll > if (charge > PAGE_SIZE) > compound_unlock_irqrestore(page, flags); > but, we have not assigned anything to 'flags' at this point, nor have we > called 'compound_lock_irqsave()' (which is what sets 'flags'). > So, I believe the 'put_back' label should be moved below the call to > compound_unlock_irqrestore() as per this patch. > > Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx> Thank you. Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@xxxxxxxxxxxxxx> Andrew, I'll move my new patces onto this. So, please pick this one 1st. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>