Hi, On Fri, Jan 21, 2011 at 03:40:35PM +0900, Minchan Kim wrote: > Hello, > > On Fri, Jan 21, 2011 at 3:28 PM, Naoya Horiguchi > <n-horiguchi@xxxxxxxxxxxxx> wrote: > > This putback_lru_pages() is inserted at cf608ac19c to allow > > memory compaction to count the number of migration failed pages. > > > > But we should not do it for a hugepage because page->lru of a hugepage > > is used differently from that of a normal page: > > > > in-use hugepage : page->lru is unlinked, > > free hugepage : page->lru is linked to the free hugepage list, > > > > so putting back hugepages to LRU lists collapses this rule. > > We just drop this change (without any impact on memory compaction.) > > > > Signed-off-by: Naoya Horiguchi <n-horiguchi@xxxxxxxxxxxxx> > > Cc: Minchan Kim <minchan.kim@xxxxxxxxx> > > As I said previously, It seems mistake during patch merge. > I didn't add it in my original patch. You can see my final patch. > https://lkml.org/lkml/2010/8/24/248 OK. > Anyway, I realized it recently so I sent the patch to Andrew. > Could you see this one? > https://lkml.org/lkml/2011/1/20/241 This patch seems not to change hugepage soft offline's behavior, so I have no objection. -- Naoya Horiguchi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>