On 10/31/2017 11:40 AM, Marc-André Lureau wrote:
> The functions are called through shmem_fcntl() only.
And no danger in removing the EXPORTs as the routines only work
with shmem file structs.
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
Reviewed-by: Mike Kravetz <mike.kravetz@xxxxxxxxxx>
--
Mike Kravetz
> ---
> include/linux/shmem_fs.h | 2 --
> mm/shmem.c | 6 ++----
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/include/linux/shmem_fs.h b/include/linux/shmem_fs.h
> index b6c3540e07bc..557d0c3b6eca 100644
> --- a/include/linux/shmem_fs.h
> +++ b/include/linux/shmem_fs.h
> @@ -109,8 +109,6 @@ extern void shmem_uncharge(struct inode *inode, long pages);
>
> #ifdef CONFIG_TMPFS
>
> -extern int shmem_add_seals(struct file *file, unsigned int seals);
> -extern int shmem_get_seals(struct file *file);
> extern long shmem_fcntl(struct file *file, unsigned int cmd, unsigned long arg);
>
> #else
> diff --git a/mm/shmem.c b/mm/shmem.c
> index 07a1d22807be..37260c5e12fa 100644
> --- a/mm/shmem.c
> +++ b/mm/shmem.c
> @@ -2722,7 +2722,7 @@ static int shmem_wait_for_pins(struct address_space *mapping)
> F_SEAL_GROW | \
> F_SEAL_WRITE)
>
> -int shmem_add_seals(struct file *file, unsigned int seals)
> +static int shmem_add_seals(struct file *file, unsigned int seals)
> {
> struct inode *inode = file_inode(file);
> struct shmem_inode_info *info = SHMEM_I(inode);
> @@ -2791,16 +2791,14 @@ int shmem_add_seals(struct file *file, unsigned int seals)
> inode_unlock(inode);
> return error;
> }
> -EXPORT_SYMBOL_GPL(shmem_add_seals);
>
> -int shmem_get_seals(struct file *file)
> +static int shmem_get_seals(struct file *file)
> {
> if (file->f_op != &shmem_file_operations)
> return -EINVAL;
>
> return SHMEM_I(file_inode(file))->seals;
> }
> -EXPORT_SYMBOL_GPL(shmem_get_seals);
>
> long shmem_fcntl(struct file *file, unsigned int cmd, unsigned long arg)
> {
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
