On 11/01/2017 02:18 PM, Thomas Gleixner wrote: > On Tue, 31 Oct 2017, Dave Hansen wrote: >> --- a/arch/x86/include/asm/pgtable_types.h~kaiser-prep-disable-global-pages 2017-10-31 15:03:49.314064402 -0700 >> +++ b/arch/x86/include/asm/pgtable_types.h 2017-10-31 15:03:49.323064827 -0700 >> @@ -47,7 +47,12 @@ >> #define _PAGE_ACCESSED (_AT(pteval_t, 1) << _PAGE_BIT_ACCESSED) >> #define _PAGE_DIRTY (_AT(pteval_t, 1) << _PAGE_BIT_DIRTY) >> #define _PAGE_PSE (_AT(pteval_t, 1) << _PAGE_BIT_PSE) >> +#ifdef CONFIG_X86_GLOBAL_PAGES >> #define _PAGE_GLOBAL (_AT(pteval_t, 1) << _PAGE_BIT_GLOBAL) >> +#else >> +/* We must ensure that kernel TLBs are unusable while in userspace */ >> +#define _PAGE_GLOBAL (_AT(pteval_t, 0)) >> +#endif > > What you really want to do here is to clear PAGE_GLOBAL in the > supported_pte_mask. probe_page_size_mask() is the proper place for that. How does something like this look? I just remove _PAGE_GLOBAL from the default __PAGE_KERNEL permissions. > https://git.kernel.org/pub/scm/linux/kernel/git/daveh/x86-kaiser.git/commit/?h=kaiser-dynamic-414rc6-20171101&id=c9f7109207f87c168a6674a4826a701bd0c7333f I was a bit worried that if we pull _PAGE_GLOBAL out of __supported_pte_mask itself, we might not be able to use it for the shadow entries that map the entry/exit code like Linus suggested. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
