>> > @@ -2278,17 +2287,23 @@ static int mem_cgroup_move_parent(struct >> > goto out; >> > if (isolate_lru_page(page)) >> > goto put; >> > + /* The page is isolated from LRU and we have no race with splitting */ >> > + charge = PAGE_SIZE << compound_order(page); >> >> Why is LRU isolation preventing the splitting? >> Oops! It seems that this comment made me confuse 'split' and 'collapse'. Yes, it's 'collapse', not 'split', that is prevented by isolation. > I use compound_lock now. I'll post clean up. > I'll wait for your patch. Thanks, Daisuke Nishimura. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>