Hello,
On Thu, Jan 20, 2011 at 11:30:35AM -0600, Christoph Lameter wrote:
> On Fri, 21 Jan 2011, Minchan Kim wrote:
>
> > diff --git a/mm/migrate.c b/mm/migrate.c
> > index 46fe8cc..7d34237 100644
> > --- a/mm/migrate.c
> > +++ b/mm/migrate.c
> > @@ -772,6 +772,7 @@ uncharge:
> > unlock:
> > unlock_page(page);
> >
> > +move_newpage:
> > if (rc != -EAGAIN) {
> > /*
> > * A page that has been migrated has all references
> > @@ -785,8 +786,6 @@ unlock:
> > putback_lru_page(page);
> > }
> >
> > -move_newpage:
> > -
> > /*
> > * Move the new page to the LRU. If migration was not successful
> > * then this will free the page.
> >
>
> What does this do? Not covered by the description.
It makes a difference for the two goto move_newpage, when rc =
0. Otherwise the function will return 0, despite
putback_lru_page(page) wasn't called (and the caller of migrate_pages
won't call putback_lru_pages if migrate_pages returned 0).
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxxx For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>