tree: git://git.cmpxchg.org/linux-mmotm.git master
head: 8c953f23aaffa1931eb463adbe10f0303ef977b1
commit: 180723ec144b81ffbe3730d20212ce5f921fe319 [171/244] kernel debug: support resetting WARN_ONCE for all architectures
config: i386-randconfig-a0-201742 (attached as .config)
compiler: gcc-5 (Debian 5.4.1-2) 5.4.1 20160904
reproduce:
git checkout 180723ec144b81ffbe3730d20212ce5f921fe319
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
In file included from include/linux/list.h:8:0,
from lib/bug.c:43:
lib/bug.c: In function 'generic_bug_clear_once':
>> lib/bug.c:212:32: error: 'module_bug_list' undeclared (first use in this function)
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
include/linux/kernel.h:927:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^
include/linux/rculist.h:277:15: note: in expansion of macro 'lockless_dereference'
container_of(lockless_dereference(ptr), type, member)
^
include/linux/rculist.h:351:13: note: in expansion of macro 'list_entry_rcu'
for (pos = list_entry_rcu((head)->next, typeof(*pos), member); \
^
lib/bug.c:212:2: note: in expansion of macro 'list_for_each_entry_rcu'
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
lib/bug.c:212:32: note: each undeclared identifier is reported only once for each function it appears in
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
include/linux/kernel.h:927:26: note: in definition of macro 'container_of'
void *__mptr = (void *)(ptr); \
^
include/linux/rculist.h:277:15: note: in expansion of macro 'lockless_dereference'
container_of(lockless_dereference(ptr), type, member)
^
include/linux/rculist.h:351:13: note: in expansion of macro 'list_entry_rcu'
for (pos = list_entry_rcu((head)->next, typeof(*pos), member); \
^
lib/bug.c:212:2: note: in expansion of macro 'list_for_each_entry_rcu'
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/linux/list.h:4,
from lib/bug.c:43:
include/linux/kernel.h:928:32: error: invalid type argument of unary '*' (have 'int')
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^
include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/rculist.h:277:2: note: in expansion of macro 'container_of'
container_of(lockless_dereference(ptr), type, member)
^
include/linux/rculist.h:351:13: note: in expansion of macro 'list_entry_rcu'
for (pos = list_entry_rcu((head)->next, typeof(*pos), member); \
^
lib/bug.c:212:2: note: in expansion of macro 'list_for_each_entry_rcu'
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
include/linux/rculist.h:351:49: error: dereferencing pointer to incomplete type 'struct module'
for (pos = list_entry_rcu((head)->next, typeof(*pos), member); \
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
#define BUILD_BUG_ON_MSG(cond, msg) compiletime_assert(!(cond), msg)
^
include/linux/kernel.h:928:2: note: in expansion of macro 'BUILD_BUG_ON_MSG'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/kernel.h:928:20: note: in expansion of macro '__same_type'
BUILD_BUG_ON_MSG(!__same_type(*(ptr), ((type *)0)->member) && \
^
include/linux/rculist.h:277:2: note: in expansion of macro 'container_of'
container_of(lockless_dereference(ptr), type, member)
^
include/linux/rculist.h:351:13: note: in expansion of macro 'list_entry_rcu'
for (pos = list_entry_rcu((head)->next, typeof(*pos), member); \
^
lib/bug.c:212:2: note: in expansion of macro 'list_for_each_entry_rcu'
list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
^
include/linux/kernel.h:929:18: error: invalid type argument of unary '*' (have 'int')
!__same_type(*(ptr), void), \
^
include/linux/compiler.h:553:19: note: in definition of macro '__compiletime_assert'
bool __cond = !(condition); \
^
include/linux/compiler.h:576:2: note: in expansion of macro '_compiletime_assert'
_compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
^
include/linux/build_bug.h:46:37: note: in expansion of macro 'compiletime_assert'
vim +/module_bug_list +212 lib/bug.c
42
> 43 #include <linux/list.h>
44 #include <linux/module.h>
45 #include <linux/kernel.h>
46 #include <linux/bug.h>
47 #include <linux/sched.h>
48 #include <linux/rculist.h>
49
50 extern struct bug_entry __start___bug_table[], __stop___bug_table[];
51
52 static inline unsigned long bug_addr(const struct bug_entry *bug)
53 {
54 #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
55 return bug->bug_addr;
56 #else
57 return (unsigned long)bug + bug->bug_addr_disp;
58 #endif
59 }
60
61 #ifdef CONFIG_MODULES
62 /* Updates are protected by module mutex */
63 static LIST_HEAD(module_bug_list);
64
65 static struct bug_entry *module_find_bug(unsigned long bugaddr)
66 {
67 struct module *mod;
68 struct bug_entry *bug = NULL;
69
70 rcu_read_lock_sched();
71 list_for_each_entry_rcu(mod, &module_bug_list, bug_list) {
72 unsigned i;
73
74 bug = mod->bug_table;
75 for (i = 0; i < mod->num_bugs; ++i, ++bug)
76 if (bugaddr == bug_addr(bug))
77 goto out;
78 }
79 bug = NULL;
80 out:
81 rcu_read_unlock_sched();
82
83 return bug;
84 }
85
86 void module_bug_finalize(const Elf_Ehdr *hdr, const Elf_Shdr *sechdrs,
87 struct module *mod)
88 {
89 char *secstrings;
90 unsigned int i;
91
92 lockdep_assert_held(&module_mutex);
93
94 mod->bug_table = NULL;
95 mod->num_bugs = 0;
96
97 /* Find the __bug_table section, if present */
98 secstrings = (char *)hdr + sechdrs[hdr->e_shstrndx].sh_offset;
99 for (i = 1; i < hdr->e_shnum; i++) {
100 if (strcmp(secstrings+sechdrs[i].sh_name, "__bug_table"))
101 continue;
102 mod->bug_table = (void *) sechdrs[i].sh_addr;
103 mod->num_bugs = sechdrs[i].sh_size / sizeof(struct bug_entry);
104 break;
105 }
106
107 /*
108 * Strictly speaking this should have a spinlock to protect against
109 * traversals, but since we only traverse on BUG()s, a spinlock
110 * could potentially lead to deadlock and thus be counter-productive.
111 * Thus, this uses RCU to safely manipulate the bug list, since BUG
112 * must run in non-interruptive state.
113 */
114 list_add_rcu(&mod->bug_list, &module_bug_list);
115 }
116
117 void module_bug_cleanup(struct module *mod)
118 {
119 lockdep_assert_held(&module_mutex);
120 list_del_rcu(&mod->bug_list);
121 }
122
123 #else
124
125 static inline struct bug_entry *module_find_bug(unsigned long bugaddr)
126 {
127 return NULL;
128 }
129 #endif
130
131 struct bug_entry *find_bug(unsigned long bugaddr)
132 {
133 struct bug_entry *bug;
134
135 for (bug = __start___bug_table; bug < __stop___bug_table; ++bug)
136 if (bugaddr == bug_addr(bug))
137 return bug;
138
139 return module_find_bug(bugaddr);
140 }
141
142 enum bug_trap_type report_bug(unsigned long bugaddr, struct pt_regs *regs)
143 {
144 struct bug_entry *bug;
145 const char *file;
146 unsigned line, warning, once, done;
147
148 if (!is_valid_bugaddr(bugaddr))
149 return BUG_TRAP_TYPE_NONE;
150
151 bug = find_bug(bugaddr);
152
153 file = NULL;
154 line = 0;
155 warning = 0;
156
157 if (bug) {
158 #ifdef CONFIG_DEBUG_BUGVERBOSE
159 #ifndef CONFIG_GENERIC_BUG_RELATIVE_POINTERS
160 file = bug->file;
161 #else
162 file = (const char *)bug + bug->file_disp;
163 #endif
164 line = bug->line;
165 #endif
166 warning = (bug->flags & BUGFLAG_WARNING) != 0;
167 once = (bug->flags & BUGFLAG_ONCE) != 0;
168 done = (bug->flags & BUGFLAG_DONE) != 0;
169
170 if (warning && once) {
171 if (done)
172 return BUG_TRAP_TYPE_WARN;
173
174 /*
175 * Since this is the only store, concurrency is not an issue.
176 */
177 bug->flags |= BUGFLAG_DONE;
178 }
179 }
180
181 if (warning) {
182 /* this is a WARN_ON rather than BUG/BUG_ON */
183 __warn(file, line, (void *)bugaddr, BUG_GET_TAINT(bug), regs,
184 NULL);
185 return BUG_TRAP_TYPE_WARN;
186 }
187
188 printk(KERN_DEFAULT "------------[ cut here ]------------\n");
189
190 if (file)
191 pr_crit("kernel BUG at %s:%u!\n", file, line);
192 else
193 pr_crit("Kernel BUG at %p [verbose debug info unavailable]\n",
194 (void *)bugaddr);
195
196 return BUG_TRAP_TYPE_BUG;
197 }
198
199 static void clear_once_table(struct bug_entry *start, struct bug_entry *end)
200 {
201 struct bug_entry *bug;
202
203 for (bug = start; bug < end; bug++)
204 bug->flags &= ~BUGFLAG_ONCE;
205 }
206
207 void generic_bug_clear_once(void)
208 {
209 struct module *mod;
210
211 rcu_read_lock_sched();
> 212 list_for_each_entry_rcu(mod, &module_bug_list, bug_list)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: application/gzip
