On Thu, Oct 19, 2017 at 07:52:12PM +0100, Roman Gushchin wrote: > This patchset makes the OOM killer cgroup-aware. Hi Andrew, I believe this code is ready for merging upstream, and it seems Michal is in agreement. There are two main things to consider, however. David would have really liked for this patchset to include knobs to influence how the algorithm picks cgroup victims. The rest of us agreed that this is beyond the scope of these patches, that the patches don't need it to be useful, and that there is nothing preventing anyone from adding configurability later on. David subsequently nacked the series as he considers it incomplete. Neither Michal nor I see technical merit in David's nack. Michal acked the implementation, but on the condition that the new behavior be opt-in, to not surprise existing users. I *think* we agree that respecting the cgroup topography during global OOM is what we should have been doing when cgroups were initially introduced; where we disagree is that I think users shouldn't have to opt in to improvements. We have done much more invasive changes to the victim selection without actual regressions in the past. Further, this change only applies to mounts of the new cgroup2. Tejun also wasn't convinced of the risk for regression, and too would prefer cgroup-awareness to be the default in cgroup2. I would ask for patch 5/6 to be dropped. Thanks -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
