On Wed, 18 Oct 2017 12:26:25 +0530 Anshuman Khandual <khandual@xxxxxxxxxxxxxxxxxx> wrote: > On 10/18/2017 12:01 PM, Balbir Singh wrote: > > vm_normal_page() normally does not return zone device public > > pages. In the absence of the visibility the output from smaps > > It never does, as it calls _vm_normal_page() with with_public > _device = false, which skips all ZONE_DEVICE pages which are > MEMORY_DEVICE_PUBLIC. Yes, probably the use of normally is not required. > > > is limited and confusing. It's hard to figure out where the > > pages are. This patch uses _vm_normal_page() to expose them > > Just a small nit, 'uses _vm_normal_page() with with_public_ > device as true'. OK, I'll reword. > > > for accounting > > Makes sense. It will help to have a small snippet of smaps output > with and without this patch demonstrating the difference. That > apart change looks good. > I can do that if its helpful Balbir Singh. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
