Hi Jan, On Thu, 2017-10-05 at 10:36 +0200, Jan Kara wrote: > Hello, > > I'm doing some work in page cache handling and I have noticed that > NFS is > the only user of mapping->a_ops->freepage callback. From a quick look > I > don't see why isn't NFS using ->releasepage / ->invalidatepage > callback as > all other filesystems do? I agree you would have to set PagePrivate > bit for > those to get called for the directory mapping however that would seem > like > a cleaner thing to do anyway - in fact you do have private data in > the > page. Just they are not pointed to by page->private but instead are > stored > as page data... Am I missing something? > > Honza I'm not understanding your point. delete_from_page_cache() doesn't call releasepage AFAICS. The point of freepage is that it is called after the page has been removed from the page cache. -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.myklebust@xxxxxxxxxxxxxxx ��.n������g��� �a��� �&ޖ)���)��h���&������梷���� �Ǟ�m������)������^�����������v���O��zf������
