Re: [PATCH 02/21] drm/i915: introduce simple gemfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Matthew Auld (2017-09-22 18:32:33)
> +static int i915_gem_object_create_shmem(struct drm_device *dev,
> +                                       struct drm_gem_object *obj,
> +                                       size_t size)
> +{
> +       struct drm_i915_private *i915 = to_i915(dev);
> +       struct file *filp;
> +
> +       drm_gem_private_object_init(dev, obj, size);
> +
> +       if (i915->mm.gemfs)
> +               filp = shmem_file_setup_with_mnt(i915->mm.gemfs, "i915", size,
> +                                                VM_NORESERVE);
> +       else
> +               filp = shmem_file_setup("i915", size, VM_NORESERVE);

Smells like the shmem_file_setup() is fishy.

This supports my argument that you should just expand shmem_file_setup()
to always take the vfsmount, passing #define TMPFS_MNT NULL.
-Chris

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href



[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [eCos]     [Asterisk Internet PBX]     [Linux API]
  Powered by Linux