On Thu, Jan 13, 2011 at 12:19 AM, Eric B Munson <emunson@xxxxxxxxx> wrote: > p is not a meaningful identifier, this patch replaces all instances > in page_alloc.c of p when used as a struct task with the more useful > tsk. > Yesterday, Andrew raise an eyebrow about that. His simple lookup found below. -- On Tue, 11 Jan 2011 13:03:22 -0800 (PST) Hugh Dickins <hughd@xxxxxxxxxx> wrote: > On Tue, 11 Jan 2011, Andrew Morton wrote: < snip > > > Oh, and since when did we use `p' to identify task_structs? > > Tsk, tsk: we've been using `p' for task_structs for years and years! Only bad people do that. "p". Really? z:/usr/src/linux-2.6.37> grep -r " \*p;" . | wc -l 2329 z:/usr/src/linux-2.6.37> grep -r "task_struct \*p" . | wc -l 824 bah. -- How about cleaning up everything in this chance? -- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxxx For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>